Why doesnt this script work?

Hi all,

I have tried using the script from http://myitforum.com/cs2/blogs/yli628/archive/2007/07/24/poweshell-script-to-check-mcafee-virus-definition.aspx but cant seem to get it working.

$erroractionpreference = "SilentlyContinue"
$a = New-Object -comobject Excel.Application
$a.visible = $True
$b = $a.Workbooks.Add()
$c = $b.Worksheets.Item(1)
$c.Cells.Item(1,1) = "Server Name"
$c.Cells.Item(1,2) = "AV Product"
$c.Cells.Item(1,3) = "Version"
$c.Cells.Item(1,4) = "Scan Engine"
$c.Cells.Item(1,5) = "Virus Definition"
$c.Cells.Item(1,6) = "Virus Definition Date"
$c.Cells.Item(1,7) = "Repository Server"
$c.Cells.Item(1,8) = "Report Time Stamp"
$d = $c.UsedRange
$d.Interior.ColorIndex = 19
$d.Font.ColorIndex = 11
$d.Font.Bold = $True
$intRow = 2
$colComputers = get-content C:\PS\ComputerList.txt
foreach ($strComputer in $colComputers)
{
$c.Cells.Item($intRow,1)  = $strComputer
Function GetRegInfo
{
$key="SOFTWARE\Network Associates\TVD\VirusScan Enterprise\CurrentVersion"
$regkey = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey([Microsoft.Win32.RegistryHive]::LocalMachine, $strComputer)
$regKey = $regKey.OpenSubKey($key)
$Product = $regKey.GetValue("Product")
$c.Cells.Item($intRow,2)  = $Product
$productver  = $regKey.GetValue("szProductVer")
$c.Cells.Item($intRow,3) = $Productver
$ScanEngine = $regKey.GetValue("szEngineVer")
$c.Cells.Item($intRow,4) = $ScanEngine
$VirDefVer = $regKey.GetValue("szVirDefVer")
$c.Cells.Item($intRow,5) = $VirDefVer
$virDefDate = $regKey.GetValue("szVirDefDate")
$c.Cells.Item($intRow,6) = $virDefDate
}
GetRegInfo
Function GetSiteInfo
{
$x = Test-path "\\$strcomputer\c$\Documents and Settings\All Users\Application Data\McAfee\Common Framework\UpdateHistory.ini"
if($x -eq "True")
{
$y = get-content "\\$strcomputer\c$\Documents and Settings\All Users\Application Data\McAfee\Common Framework\UpdateHistory.ini"
$z = $y[3]
$SiteServer = $z.substring(19,($z.length-19))
}
$c.Cells.Item($intRow,7) = $SiteServer.ToUpper()
}
GetSiteInfo
$c.Cells.Item($intRow,8) = Get-date

$intRow = $intRow + 1

}
$d.EntireColumn.AutoFit()
cls

The script runs and Microsoft Excel Open but no information gets populated.  I am using Microsoft Excel 2003 is this why?

Thanks all.

Are there any computer names populating the file C:\PS\ComputerList.txt ?

When all else fails, begin inserting statements that echo information to the screen.  Print statements that tell you what part of the code is going to execute / is executing / did execute so you can track its progress.  Also echo the data from key variables.  That will tell you what is working and what is not.

It looks like you are redefining an object:

$regkey = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey([Microsoft.Win32.RegistryHive]::LocalMachine, $strComputer)
$regKey = $regKey.OpenSubKey($key)

Try this:
$regBase = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey([Microsoft.Win32.RegistryHive]::LocalMachine, $strComputer)
$regKey = $regBase.OpenSubKey($key)

I would also try just the PowerShell code at a PS prompt:

$strcomputer=$env:computername
$key= "SOFTWARE\Network Associates\TVD\VirusScan Enterprise\CurrentVersion"
$regbase = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey([Microsoft.Win32.RegistryHive]::LocalMachine, $strComputer)
$regKey = $regbase.OpenSubKey($key)
$Product = $regKey.GetValue("Product")
$Product

Do you get a product listed? This will be for the local computer.  Change $strComputer to a remote computer and try again.  Make sure this part is working then tackle the rest of the script.