need help in SELECT CASE statement in VBSCRIPT

Forums

My Profile

Inbox

Address Book

My Subscription

My Forums

need help in SELECT CASE statement in VBSCRIPT

Logged in as: Guest

arrSession:exec spGetSession 2,2,35172

	Active Users: There are 0 members and 0 guests.
	Users viewing this topic: none

Printable Version

All Forums >> [Scripting] >> WSH & Client Side VBScript >> need help in SELECT CASE statement in VBSCRIPT
Do you like VisualBasicScript.com? Link to us and help spread the word about our forum. Thanks!

Page: [1]

Message

<< Older Topic Newer Topic >>

need help in SELECT CASE statement in VBSCRIPT - 6/6/2006 5:27:02 PM

blakeph

Posts: 17
Score: 0
Joined: 5/28/2006
Status: offline

hi everyone!
i have a VB Script that will export a certain files from a directory, and this script will run twice a day, once in the morning and once in the afternoon, but am having trouble getting it to work, my code looks like this:

'get the current date and hour
currentDate = Date
currentHour = Hour(Time)
'extract the day of the week information
weekDayValue = weekday(currentDate)
dayHourValue = Hour(Time)
dim emailShell
Set emailShell = CreateObject("WScript.Shell")
select case = weekDayValue
case "1"
if weekDayValue = 1 and dayHourValue < 12 then
emailShell.Run "ExportSundayAM.bat", 0, true
else
emailShell.Run "ExportSundayPM.bat", 0, true
end if
case "2"
if weekDayValue = 2 and dayHourValue < 12 then
emailShell.Run "ExportMondayAM.bat", 0, true
else
emailShell.Run "ExportMondayPM.bat", 0, true
end if
case "3"
if weekDayValue = 3 and dayHourValue < 12 then
emailShell.Run "ExportTuesdayAM.bat", 0, true
else
emailShell.Run "ExportTuesdayPM.bat", 0, true
end if
case "4"
if weekDayValue = 4 and dayHourValue < 12 then
emailShell.Run "ExportWednesdayAM.bat", 0, true
else
emailShell.Run "ExportWednesdayPM.bat", 0, true
end if
case "5"
elseif weekDayValue = 5 and dayHourValue < 12 then
emailShell.Run "ExportThursdayAM.bat", 0, true
else
emailShell.Run "ExportThursdayPM.bat", 0, true
end if
case "6"
elseif weekDayValue = 6 and dayHourValue < 12 then
emailShell.Run "ExportFridayAM.bat", 0, true
else
emailShell.Run "ExportFridayPM.bat", 0, true
end if
case "7"
elseif weekDayValue = 7 and dayHourValue < 12 then
emailShell.Run "ExportSaturdayAM.bat", 0, true
else
emailShell.Run "ExportSaturdayPM.bat", 0, true
end if
case else 
Wscript.Echo "error!"
end select
'wscript.quit

any help would be highly appreciated. thanks!

Post #: 1

RE: need help in SELECT CASE statement in VBSCRIPT - 6/6/2006 5:53:58 PM

ginolard

Posts: 1051
Score: 21
Joined: 8/10/2005
Status: offline

The IF statements testing the weekday value are redundant because you are doing that via the Select Case method. Also, it's not Select Case = weekdayValue but simply Select Case weekDayValue. Finally, you don't need the ElseIf statements, a simple IF will do.

Here's your code with the run statements replaced with echo statements and the above problems fixed.

'get the current date and hour
currentDate = Date
currentHour = Hour(Time)
'extract the day of the week information
weekDayValue = weekday(currentDate)
dayHourValue = Hour(Time)
dim emailShell
Set emailShell = CreateObject("WScript.Shell")
select Case weekDayValue
case "1"
if  dayHourValue < 12 then
wscript.echo  "ExportSundayAM.bat"
else
wscript.echo  "ExportSundayPM.bat"
end if
case "2"
if  dayHourValue < 12 then
wscript.echo  "ExportMondayAM.bat"
else
wscript.echo  "ExportMondayPM.bat"
end if
case "3"
if  dayHourValue < 12 then
wscript.echo  "ExportTuesdayAM.bat"
else
wscript.echo  "ExportTuesdayPM.bat"
end if
case "4"
if  dayHourValue < 12 then
wscript.echo  "ExportWednesdayAM.bat"
else
wscript.echo  "ExportWednesdayPM.bat"
end if
case "5"
if  dayHourValue < 12 then
wscript.echo  "ExportThursdayAM.bat"
else
wscript.echo  "ExportThursdayPM.bat"
end if
case "6"
if  dayHourValue < 12 then
wscript.echo  "ExportFridayAM.bat"
else
wscript.echo  "ExportFridayPM.bat"
end if
Case "7"
if  dayHourValue < 12 then
wscript.echo  "ExportSaturdayAM.bat"
Else
wscript.echo  "ExportSaturdayPM.bat"
end if
case else 
Wscript.Echo "error!"
end select
'wscript.quit

_____________________________

Author of ManagePC - http://managepc.net
AD Query Template - http://www.visualbasicscript.com/m_40609/tm.htm
Consolidated Scripting Framework - http://www.visualbasicscript.com/m_59109/tm.htm

(in reply to blakeph)