quote:

---

Originally posted by Xandros

Some questions...
1. Is there a USERS folder below REVIEW\DEPARTMENTS? If not, how do/will you avoid filename collisions?

2. Are the *.fin files to be COPIED or MOVED? (i.e., will they still exist in their original location after the scheduled job runs?).

3. If they are just COPIED, should they be re-COPIED on subsequent runs if they are newer than the copy already in the REVIEW... path?

---

quote:

---

Originally posted by ehvbs

While we wait for further information - do you think that
this (kind of) code would be a frame'work'/starting point
to develop a solution?
Dim aRVal aRVal = Array( 0, "done" ) Dim aTests aTests = Array( "C:\Temp\DRAFTS\DEPARTMENTS\USERS\andy\" _ , "C:\Temp\DRAFTS\DEPARTMENTS\USERS\barbara\" _ , "C:\Temp\DRAFTS\DEPARTMENTS\USERS\carl\" _ ) ' [un]comment to do current task while developing ' aRVal = doFinCSetup( aTests ) ' aRVal = doRealWork( aTests ) aRVal = doCheck( aTests ) WScript.Echo aRVal( 0 ), aRVal( 1 ) WScript.Quit 0 Function doFinCSetup( aTests ) Const SW_SHOWMINNOACTIVE = 7 Dim aRVal aRVal = Array( 1, "doFinCSetup - not implemented yet" ) Dim oFS Dim sPath Dim sTmp Dim vRet Set oFS = CreateObject( "Scripting.FileSystemObject" ) For Each sPath In aTests sTmp = sPath If oFS.FolderExists( sPath ) Then sTmp = sTmp + " exists." Else sTmp = sTmp + " must be created." WScript.Echo sTmp ' oFS.CreateFolder( sPath ) ' http://www.windowsitpro.com/WindowsScripting/Article/ArticleID/42368/42368.html ' Mkdir automatically creates C:\tmplogs and C:\tmplogs\2004 if they don't exist. ' For unknown reasons, Microsoft didn't design the CreateFolder method in the FSO ' model to create folders as Mkdir does; CreateFolder merely returns the error ' message Path not found when a folder doesn't exist. ' sTmp = "mkdir " + sPath sTmp = "cmd /c mkdir " + sPath vRet = CreateObject( "WScript.Shell" ).Run( sTmp, SW_SHOWMINNOACTIVE, True ) sTmp = "'" + sTmp + "' returns: |" & vRet & "|" oFS.CreateTextFile( sPath + "test.txt" ).WriteLine "Just trying" oFS.CreateTextFile( sPath + "test.fin" ).WriteLine "Just trying" End If WScript.Echo sTmp Next For Each sPath in aTests For Each sTmp In Array( "test.txt", "test.fin" ) sTmp = sPath + sTmp If oFS.FileExists( sTmp ) Then sTmp = sTmp + " exists (qed)" Else sTmp = sTmp + " not found." End If WScript.Echo sTmp Next Next aRVal = Array( 0, "doFinCSetup - done" ) Set oFS = Nothing doFinCSetup = aRVal End Function Function doRealWork( aTests ) Const SW_SHOWMINNOACTIVE = 7 Dim aRVal aRVal = Array( 1, "doRealWork - not implemented yet" ) doRealWork = aRVal End Function Function doCheck( aTests ) Const SW_SHOWMINNOACTIVE = 7 Dim aRVal aRVal = Array( 1, "doCheck - not implemented yet" ) Dim oFS Dim sPath Dim sDPath Dim sTmp Set oFS = CreateObject( "Scripting.FileSystemObject" ) For Each sPath In aTests sDPath = Replace( sPath, "C:\Temp\DRAFTS\", "C:\Temp\REVIEW\" ) If oFS.FolderExists( sDPath ) Then sTmp = sDPath + " exists." Else sTmp = sDPath + " must be created." End If WScript.Echo sTmp Next Set oFS = Nothing doCheck = aRVal End Function
      

---

• It keeps the code needed for different sub problems of whole solution separate


• You can switch between different attempts to solve a sub problem by the simple
  method of [un]commenting calls to subs/functions
  

• To work with your problem, I need to set up a testing environment (no 300 users
  on my maschine); doFinCSetup() will do this for me (and I hope for Xandros too);
  you don't need it, but if you find some flaw in the concept or the code we can
  concentrate on just one function
  


• Now I know that there are no user directories under REVIEW\DEPARTMENTS; the
  concept of doCheck() - looking for files in parallel directories - is wrong; we
  have to assert that for each .fin file under DRAFTS\DEPARTMENTS there is a
  file with a corresponding name directly REVIEW\DEPARTMENTS
  


• To tackle the sub problem "corresponding name" I insert "aRVal = doFName()"
  into the main code to call this function
  ' julian date, employee id, series Function doFName() Const ciID = 0 Dim aRVal Dim sTmp aRVal = Array( 1, "doFName - not implemented yet" ) Dim sFSpec sFSpec = "C:\Temp\DRAFTS\DEPARTMENTS\USERS\andy\test.fin" sTmp = "Review file name for: " + sFSpec WScript.Echo sTmp Dim oFS Dim dicUserInfo Set oFS = CreateObject( "Scripting.FileSystemObject" ) Set dicUserInfo = CreateObject( "Scripting.Dictionary" ) dicUserInfo.Add "andy", Array( "IDofAndy" ) Dim sUser Dim dtFile Dim sId Dim sSeries dtFile = oFS.GetFile( sFSpec ).DateLastModified sTmp = "last modified: " + CStr( dtFile ) WScript.Echo sTmp sUser = oFS.GetBaseName( oFS.GetParentFolderName( sFSpec ) ) sTmp = "User: " + sUser WScript.Echo sTmp sId = dicUserInfo( sUser )( ciID ) sTmp = "employee id: " + sId WScript.Echo sTmp sSeries = "Don't know" sTmp = "series: " + sSeries WScript.Echo sTmp doFName = aRVal End Function
        
  Now we can discuss/work on/test the format for the date in the new file name, the best
  method to determine the exmployee id (hard coding into script, database access, ...) and
  the meaning of 'series'.
  

• 06/28/2005 17:00 carl saves his work in DRAFTS\DEP01\carl\xxx.fin and goes home


• 06/29/2005 01:00 the script copies the file to \REVIEW\DEP01\yyy.fin


• 06/29/2005 11:00 reviewer robert saves his changes to yyy.fin


• 06/29/2005 11:01 carl changes DRAFTS\DEP01\carl\xxx.fin


• 06/30/2005 01:00 the script copies the file to \REVIEW\DEP01\yyy.fin and clobbers robert's work

quote:

---

Originally posted by bastardchyld

OK Here is what I would like to do.

I have a file structure like this

DRAFTS\DEPARTMENTS\USERS - (each dept has there own folders and the users are in their own folder under their dept)

and

REVIEW\DEPARTMENTS

When users complete certain documents, they change the file extension to .fin and one of our departments has the job of going through each users folders and making a copy of all .fin files into the review section under the appropriate users. They then look over them to ensure that they are correct. I would like to write a script that could be run in a scheduled task every 6 hours or so that would go through all the subfolders of drafts, look for .fin files and make a copy based on their dept into the review directory.

I think that I need to dump the absolute paths of all the .fin files to a text file, so that I can use ReadLine to determine what directory it should be copied too. Is this the best way to do this? Any advice or code samples that you can point me to would be great.

---

quote:

---

Originally posted by Xandros

Likewise, it appears I should have read more closely as well . I believe I implemented the directory traversal logic correctly, however. Here is a modified version of the script I posted earlier that limits the processing to files already named with the ".fin" extension. It has two additional options coded (but disabled, by default). It can optionally remove the file after copying and it can optionally remove old files which were previously copied manually.

'*****************************************************************************************
' Promote.vbs
'
' This script "promotes" files from the DRAFTS\departments\users folders to the
' REVIEW\departments folders. Only files with the extension of ".fin" are processed.
' Copied files can optionally be deleted from users folder.
'
' Only copies files that are not already at destination or are newer than at destination.
' Files are determined to be newer if the "DateLastUpdated" is more recent.
'
'*****************************************************************************************

Option Explicit

Dim oFSO
Dim DraftsRoot, ReviewRoot
Dim buFileCount, ofFileCount
Dim StopNow, arrDept, n
Dim Folder
Dim DeleteAfterCopy
Dim DeleteOldFiles
Dim Message

DraftsRoot = "E:\ee\drafts"
ReviewRoot = "E:\ee\review"
DeleteAfterCopy = False ' change to TRUE if you want to remove the original file
' from the user's folder after copying it to REVIEW.

DeleteOldFiles = False ' change to TRUE if you want to remove old ".FIN" files
' from the user's folder (they were previously copied to REVIEW)

buFileCount = 0
ofFileCount = 0

Set oFSO = CreateObject("Scripting.FileSystemObject")

'-- determine if directory root structures exist...
If Not oFSO.FolderExists(DraftsRoot) Then
Wscript.Echo "Path to root of DRAFTS is invalid."
StopNow = True
End If

If Not oFSO.FolderExists(ReviewRoot) Then
Wscript.Echo "Path to root of REVIEW is invalid."
StopNow = True
End If

If StopNow Then
Wscript.Echo "Terminating due to error(s)."
Wscript.Quit(16)
End If

'-- ensure that all department folders exist under REVIEW
arrDept = GetFolders(DraftsRoot)
For n = 0 To UBound(arrDept)
Folder = ReviewRoot & arrDept(n)
If Not oFSO.FolderExists(Folder) Then
oFSO.CreateFolder Folder
End If
Next

'-- Let's get to work...
For n = 0 To UBound(arrDept)
ScanFiles DraftsRoot & arrDept(n), ReviewRoot & arrDept(n)
Next

Message = "Finished! " & buFileCount & " files backed up"
If DeleteAfterCopy Then
Message = Message & " files backed up and removed"
End If

If DeleteOldFiles Then
Message = Message & ", " & ofFileCount & " old files removed"
End If
Wscript.Echo Message & "."

Set oFSO = Nothing

Sub ScanFiles(SrcPath, DestPath)
Dim oFolder, colFiles
Dim FileName, oFile
Dim SrcFile, oSrcFile
Dim DestFile, oDestFile
Dim arrUser, UserPath
Dim n

arrUser = GetFolders(SrcPath)
For n = 0 To UBound(arrUser)
UserPath = SrcPath & arrUser(n)
Set oFolder = oFSO.GetFolder(UserPath)
Set colFiles = oFolder.Files
For Each oFile In colFiles
FileName = oFile.Name
If LCase(Right(FileName, 4)) = ".fin" Then
SrcFile = UserPath & "\" & FileName
Set oSrcFile = oFSO.GetFile(SrcFile)
DestFile = DestPath & "\" & FileName

If Not oFSO.FileExists(DestFile) Then
oSrcFile.Copy DestFile, False
buFileCount = buFileCount + 1
If DeleteAfterCopy Then
oSrcFile.Delete
End If
Else
Set oDestFile = oFSO.GetFile(DestFile)
If oSrcFile.DateLastModified > oDestFile.DateLastModified Then
oSrcFile.Copy oDestFile, True
buFileCount = buFileCount + 1
If DeleteAfterCopy Then
oSrcFile.Delete
End If
ElseIf DeleteOldFiles Then
oSrcFile.Delete
ofFileCount = ofFileCount + 1
End If
End If
End If
Next
Next

Set oSrcFile = Nothing
Set oDestFile = Nothing
Set colFiles = Nothing
Set oFolder = Nothing

End Sub

Function GetFolders(BaseFolder)
Dim oBaseFolder
Dim SubFolder
Dim strArr

Set oBaseFolder = oFSO.GetFolder(BaseFolder)
For Each SubFolder In oBaseFolder.SubFolders
If Not IsEmpty(SubFolder) Then
strArr = strArr & "+" & Mid(SubFolder, Len(BaseFolder) + 1)
End If
Next

GetFolders = Split(Mid(strArr, 2), "+")
Set oBaseFolder = Nothing

End Function

---