My first PHP, needs criticism

Forums

My Profile

Inbox

Address Book

My Subscription

My Forums

My first PHP, needs criticism

Logged in as: Guest

arrSession:exec spGetSession 2,7,40277

	Active Users: There are 0 members and 0 guests.
	Users viewing this topic: none

Printable Version

All Forums >> [General Forum] >> Other Programming/Scripting Languages >> My first PHP, needs criticism
Do you like VisualBasicScript.com? Link to us and help spread the word about our forum. Thanks!

Page: [1]

Message

<< Older Topic Newer Topic >>

My first PHP, needs criticism - 11/30/2006 10:53:12 PM

TNO

Posts: 1399
Score: 16
Joined: 12/18/2004
From: thenewobjective.com
Status: offline

Since my current webhost only supports PHP, I've been forced to make a program in it (crying on the inside)....

This PHP is designed to update an XML file when the following variables are passed through the URL:

.../map.php?map=####&id=####&path=####&x=####&y=####

Are there any obvious blunders in my code that you could point out?

#Get variables passed to this page
icon=$_GET['id'];
map=$_GET['map'];
path=$_GET['path'];
x=$_GET['x'];
y=$_GET['y'];

# to load xml from a file
$doc = xmldocfile( ".../map.xml" ) or die("Database could not be loaded");

# get root node "guilds"
$guilds = $doc->root();

#create xpath expression to test for existence of an icon with the id tag:
$xp = new domxpath($doc)
$result = $xp->query("/guilds/icon[@id=$icon]")

#If icon of id exists, update information
if($result!=Null){
  $result.childNodes[0]->data = $map
  $result.childNodes[1]->data = $path
  $result.childNodes[2]->data = $x
  $result.childNodes[3]->data = $y
}
#else create nodes with information,
else {
  //create <icon> node under guilds node
  $iconNode = make_node($guilds,"icon","");
  //set id attribute
  $iconNode->setattr("id",icon);
  //create nodes under <icon>
  $iconNode->new_child("map",$map)
  $iconNode->new_child("path",$path)
  $iconNode->new_child("x",$x)
  $iconNode->new_child("y",$y)
}

#save doc
$doc->save(".../map.xml");

//////////////////////////
# function for making child nodes
function make_node($parent,$name,$content)
{
  # adds a new child node to parent node
  $parent->new_child($name,$content);

# return the newly added child as a reference
  return $parent->lastchild();
}

Sample XML file:

< Message edited by TNO -- 11/30/2006 11:05:22 PM >

_____________________________

To iterate is human, to recurse divine. -- L. Peter Deutsch