RE: Error Message

Forums

My Profile

Inbox

Address Book

My Subscription

My Forums

RE: Error Message

Logged in as: Guest

arrSession:exec spGetSession 2,2,45108

	Active Users: There are 0 members and 0 guests.
	Users viewing this topic: none

Printable Version

All Forums >> [Scripting] >> WSH & Client Side VBScript >> RE: Error Message
Do you like VisualBasicScript.com? Link to us and help spread the word about our forum. Thanks!

Page: << < prev 1 [2]

Message

<< Older Topic Newer Topic >>

RE: Error Message - 4/9/2007 7:56:20 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Thanks I will give it a go and let you guys know how I get on..

Many Thanks

James

(in reply to ebgreen)

Post #: 21

RE: Error Message - 4/11/2007 10:02:07 PM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Hello,

I have tried what you have asked. Please could you guys have a quick glance over it and let me know whats going on or if its completly overkill?

I have done pretty much the same thing for the other vbs files which it runs from within the script...

If you guys give it the OK then I will start testing it...

Many Thanks

James

Option Explicit
 On Error Resume Next

Dim strResponse, WshShell, objFSO, objFile, ierr, strComputer, StdOut, oReg, strKeyPath
Dim arrSubKeys, subkey, strValueName, dwValue, oFS, fso, f, objWMIService, colProc, ConsoleUser
Dim objMessage, objnet, oProcess, sch, sUser, sDomain, cdoConfig
Const ForReading = 1  :  Const ForWriting = 2  :  Const ForAppending = 8
  Set WshShell = CreateObject("WScript.Shell")
  Set objFSO = CreateObject("Scripting.FileSystemObject")
  Const HKEY_LOCAL_MACHINE = &H80000002
strComputer = "."
Set StdOut = WScript.StdOut

Set oReg=GetObject("winmgmts:{impersonationLevel=impersonate}!\\" &_ 
strComputer & "\root\default:StdRegProv")

strKeyPath = "SOFTWARE\Microsoft\Windows\CurrentVersion\Syncmgr\AutoSync"
oReg.EnumKey HKEY_LOCAL_MACHINE, strKeyPath, arrSubKeys

For Each subkey In arrSubKeys
   strValueName = "LogOff"
dwValue = 0
oReg.SetDWORDValue HKEY_LOCAL_MACHINE,strKeyPath & "\" & subkey & "\LAN Connection",strValueName,dwValue 
   Next   
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If     
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  WScript.Sleep 5000
  objFile.WriteLine "Maintenance/Cleanup Started: " & Now   
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If  
  objFile.Close
  WScript.Sleep 5000
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 1/6 Running Disk Cleanup (Cleaning Temp Files) ..."   
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If  
  objfile.close
  
  WshShell.Run "C:\Maintenance\CleanupScripts\DiskCleanup.vbs", 0, True   
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If  
  If objFSO.FolderExists("c:\program files\netscape") Then
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 2/6 Netscape Found Removing (Removing Netscape Software) ..."  
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If  
  objfile.Close
  
      WshShell.Run "C:\Maintenance\CleanupScripts\NetscapeAppRemoval.VBS", 0, True       
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
      WshShell.run "C:\Maintenance\CleanupScripts\NetscapeFolderRemoval.bat", 0, True      
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  Else
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Netscape Not Found Proceeding To Next Step..."
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close
  End If
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 3/6 Removing Local Profiles (Removing Unused/Old Local Profiles) ..."
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close   
  WshShell.Run "C:\Maintenance\CleanupScripts\LocalProfileCleanup.VBS", 0, True
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If       
  If objFSO.FileExists("c:\program files\CCleaner\ccleaner.exe") Then
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 4/6 Running CCleaner (In Depth Clean) ..."
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close 
      WshShell.run "c:\Maintenance\AutoCleaner.lnk"
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
      WScript.Sleep 600000
      WshShell.run "c:\Maintenance\AutoCleaner.lnk"
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
      WScript.Sleep 600000
 Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
      objFile.WriteLine ("CCleaner Cleaned Successfully! " & Now)
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
      objfile.Close
  Else
      WshShell.Run "C:\Maintenance\CleanupScripts\CCleaner.VBS", 0, True  
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If   
  End If
  
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 5/6 Cleaning Registry (Cleaning The PC's Index) ..."
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close 
  WshShell.Run "C:\Maintenance\CleanupScripts\Regseeker.VBS", 0, True
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If    
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine "Step 6/6 Defragmenting The C:\ Drive (Moving Files For Quicker Access) ..."
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close  
  WshShell.Run "C:\Maintenance\Contig.exe"
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  WScript.Sleep 30000
  WshShell.SendKeys "{ENTER}"
  WshShell.Run "C:\Maintenance\Contig.exe -s -q c:\*.*"
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine ("Defragmentation Completed Successfully! " & Now)
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close
  
  WScript.Sleep 10000
  
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine ("Maintenance/Cleanup Completed Successfully! " & Now)
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objfile.Close
  
  Set fso = CreateObject("Scripting.FileSystemObject")
  Set f = fso.GetFile("C:\Program Files\maintenance\Maintenance_Error_Log.txt")
If f.Size >= 1 Then
Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
objFile.WriteLine ("Sending Error Information To Servicedesk...")
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
objfile.Close
Email()
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
objFile.WriteLine ("Error Information Successfully Sent")
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
objfile.Close
End If

Sub Email
strComputer="." 'change this to the name of the remote machine
  Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2")
  Set colProc = objWmiService.ExecQuery("Select Name from Win32_Process"  & " Where Name='explorer.exe' and  SessionID=0")
  ConsoleUser = ""
  
If  colProc.Count > 0 Then 
    For Each oProcess In colProc 
        oProcess.GetOwner sUser, sDomain 
        Exit For 
     Next 
End If 
  
sch = "[link=http://schemas.microsoft.com/cdo/configuration/]http://schemas.microsoft.com/cdo/configuration/[/link]" 
Set cdoConfig = CreateObject("CDO.Configuration") 
  With cdoConfig.Fields 
      .Item(sch & "sendusing") = 2 ' cdoSendUsingPort 
      .Item(sch & "smtpserver") = "scnexchange.stockport.gov.uk" 
      .update 
  End With 
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
Set objMessage = CreateObject("CDO.Message")
Set objNet=CreateObject("Wscript.Network")
  With objMessage
      Set .Configuration = cdoConfig 
      .Subject = "Maintenance/Cleanup Error Log"
      .From = sUser & "@stockport.gov.uk" 
      .To = "[email=servicedesk@stockport.gov.uk]servicedesk@stockport.gov.uk[/email]"
      .TextBody = "Hostname: " & objNet.ComputerName & " This PC has Run Maintenance and created Errors. Please check the attached File." 
      .AddAttachment "C:\Program Files\maintenance\Maintenance_Error_Log.txt"
      .Send
  End With
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
End Sub
  Set objFile = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
  objFile.WriteLine ("Shutting Down.... ")
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  objFile.close
  WScript.Sleep 10000
  WshShell.run "C:\Maintenance\CleanupScripts\ShutDown.bat"
If err <> 0 Then 
Error(Err.Number, Err.Description, Err.Source) 
End If 
  
Sub Error(nNum, strDes, strSrc) 
Set oTS = objFSO.OpenTextFile("c:\Program Files\Maintenance\Maintenance_Error_Log.txt", ForAppending, True) 
oTS.WriteLine "Error: " & Now 
oTS.WriteLine "Function: " & WScript.ScriptName 
oTS.WriteLine "Error Number: " & nNum 
oTS.WriteLine "Error Source: " & strSrc 
oTS.WriteLine "Error Description: " & strDes 
oTS.WriteLine 
Err.Clear 
oTS.Close 
End If 
On Error GoTo 0 
End Sub

(in reply to ebgreen)

Post #: 22

RE: Error Message - 4/12/2007 1:15:21 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

That is probably more error checking than I would put in but there isn't really any inherent reason not to. The only thing that I would say is that the normal way that I do this is to not use a global On Error Resume Next. Instead I put On Error Resume Next right before a line that I think might fail. Then after I check the value of Err.Number, I will put On Error Goto 0. This way if there is some error that you did not expect then you will actually see the error instead of having the error masked by a global On Error Resume Next.

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 23

RE: Error Message - 4/12/2007 3:15:55 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Hello,

I can understand where your coming from but I would need any errors to go sttraght into that text file and not pop up on screen and stop the script as if there is any data in the text file it will then send off the files to the servicedesk so we can lok into them.

Would your suggestion still do this?

Many Thanks

James

(in reply to ebgreen)

Post #: 24

RE: Error Message - 4/12/2007 4:59:24 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

If you would prefer the script to never pop any error to the end user, then the Global On Error Resume next is the way to go.

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 25

RE: Error Message - 4/12/2007 6:21:50 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

So in theory it should be good to go now it will only ever log errors to that text file and then it will use a sub to mail off to the servicedesk.

Brilliant thanks for all your help and teachings!! :)

Its just my manager has set me this task and I have had to learn VBScript on the fly by doing things here and there and hence me posting like crazy in here but I would like to thank everyone who has helped me. Along my journey I have leared loads!!!

Now my manager has seen my efforts he has decided to send me on a VBScript course!!! Its a little late but hey ho its always welcome I might actually be able to get my head around it more! The only snag is its in November! A long way off but much learning to be done by then!

Again thanks for everything guys!!!

I will call again when there is something else my bible does not tell me or I cant get woking properly! :)

James

(in reply to ebgreen)

Post #: 26

RE: Error Message - 4/12/2007 8:22:25 PM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Quick Question

Would the following code be ignored

If I am correct in thinking that the Global On Error Resume Next would ignore this if the registry entry was not there and just proceed as it does not refer he error handling to my text file and it would not pop up on screan to the user???

Am I correct?

Many Thanks

James

(in reply to morpheus83uk)

Post #: 27

RE: Error Message - 4/12/2007 10:04:02 PM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Oh and when I use the If Statement I get an error saying:

Cannot use parentheses when calling a Sub

I dont get why it is saying this is it because the variables are diffrent in the sub than they are when there calling the sub?

Many Thanks

James

(in reply to morpheus83uk)

Post #: 28

RE: Error Message - 4/13/2007 12:22:07 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

Basicly On Error Resume Next makes the script try to run every line just like it normally does. It just means that if the line errors then it will just ignore the error and go on to the next line of execution. As for the error, your Error routine is a Sub so when you call it you need to remove the () so this line:

Error(Err.Number, Err.Description, Err.Source)

Should be:

Error Err.Number, Err.Description, Err.Source

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 29

RE: Error Message - 4/13/2007 2:02:08 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Thanks for that so my error would get ignored as I have just found! :)

Thanks for the info on the error :)

James

(in reply to ebgreen)

Post #: 30

RE: Error Message - 4/30/2007 2:42:07 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

Hello,

With my Sub Error:

And my if statement:

If the code error's at any point it still does not E-Mail like it is supposed to... It errored because it could not find a file... I had moved it to test the error reporting...

Any help appreciated.

James

(in reply to morpheus83uk)

Post #: 31

RE: Error Message - 4/30/2007 3:02:32 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

I don't see anything in that code that would generate an email.

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 32

RE: Error Message - 4/30/2007 9:13:14 PM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

No there isnt anything in that code...

What is suspposed to happen is that it should log the error information into the test file and then part way through the code it will check the file size of the text file and then it will send an E-Mail based on that...

The code I have for this is:

'Checking For Information In Error Log  
  Set fso = CreateObject("Scripting.FileSystemObject")
  Set f = fso.GetFile("C:\Program Files\maintenance\Maintenance_Error_Log.txt")
If f.Size >= 1 Then
Set objFile = fso.OpenTextFile("C:\Program Files\Maintenance\Maintenance_Log.txt", ForAppending, True)
objFile.WriteLine ("Sending Error Information To Servicedesk...")
If Err.number <> 0 Then 
Error Err.Number, Err.Description, Err.Source  
End If 
objfile.Close
'If Error Information Found E-Mails To Serviceddesk
Call Email()
If Err.number <> 0 Then 
Error Err.Number, Err.Description, Err.Source  
End If 
Sub Email
strComputer="." 'change this to the name of the remote machine
  Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\CIMV2")
  Set colProc = objWMIService.ExecQuery("Select Name from Win32_Process"  & " Where Name='explorer.exe' and  SessionID=0")
  ConsoleUser = ""
  
If  colProc.Count > 0 Then 
    For Each oProcess In colProc 
        oProcess.GetOwner sUser, sDomain 
        Exit For 
     Next 
End If 
  
sch = "[link=http://schemas.microsoft.com/cdo/configuration/]http://schemas.microsoft.com/cdo/configuration/[/link]" 
Set cdoConfig = CreateObject("CDO.Configuration") 
'Servier Information
  With cdoConfig.Fields 
      .Item(sch & "sendusing") = 2 ' cdoSendUsingPort 
      .Item(sch & "smtpserver") = "ServerNameHere" 
      .update 
  End With 
If Err.number <> 0 Then 
Error Err.Number, Err.Description, Err.Source  
End If 
Set objMessage = CreateObject("CDO.Message")
Set objNet=CreateObject("Wscript.Network")
'Message Content
  With objMessage
      Set .Configuration = cdoConfig 
      .Subject = "Maintenance/Cleanup Error Log"
      .From = sUser & "@companynamehere" 
      .To = Address@companynamehere
      .TextBody = "Hostname: " & objNet.ComputerName & " This PC has Run Maintenance and created Errors. Please check the attached File." 
      .AddAttachment "C:\Program Files\maintenance\Maintenance_Error_Log.txt"
      .Send
  End With
If Err.number <> 0 Then 
Error Err.Number, Err.Description, Err.Source  
End If 
End Sub

I have taken out the proper server names in the above code just for security reasons I am sure your all ok with this...

Any Suggestions?

Many Thanks

James

(in reply to ebgreen)

Post #: 33

RE: Error Message - 5/1/2007 12:55:00 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

Hmmm...I don't typically send email that way. Does the email portion work if you pull it out and just try to run it by itself?

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 34

RE: Error Message - 5/1/2007 1:55:12 AM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

It does indeed... but the thing is as well its not actually writing into the text file either...

Any suggestions?

Many Thanks

James

(in reply to ebgreen)

Post #: 35

RE: Error Message - 5/1/2007 1:59:52 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

Ok, if it isn't writing to the file then is the error sub getting called at all?

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)

Post #: 36

RE: Error Message - 5/1/2007 7:06:28 PM

morpheus83uk

Posts: 305
Score: 0
Joined: 8/21/2006
Status: offline

I presume so...

Is there an easy way to test?

Many Thanks

James

(in reply to ebgreen)

Post #: 37

RE: Error Message - 5/2/2007 1:04:34 AM

ebgreen

Posts: 4613
Score: 31
Joined: 7/12/2005
Status: offline

Put a WScript.Echo into the error sub to see if it is called at all.

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to morpheus83uk)