How to compare Multi dimensional arrays

Forums

My Profile

Inbox

Address Book

My Subscription

My Forums

How to compare Multi dimensional arrays

Logged in as: Guest

arrSession:exec spGetSession 2,2,59911

	Active Users: There are 0 members and 0 guests.
	Users viewing this topic: none

Printable Version

All Forums >> [Scripting] >> WSH & Client Side VBScript >> How to compare Multi dimensional arrays
Do you like VisualBasicScript.com? Link to us and help spread the word about our forum. Thanks!

Page: [1]

Message

<< Older Topic Newer Topic >>

How to compare Multi dimensional arrays - 5/7/2008 2:36:38 AM

lordsords

Posts: 3
Score: 0
Joined: 5/7/2008
Status: offline

Hi everyone,

I am writing a script that would compare 2 tables inside an MSI file.
So I am trying to do it by reading each table into a multidimensional array and then comparing them.

The problem is that comparing takes a lot of time if the arrays are bigger.
e.g.
~55sec if arrays are 4000 entries each
~1min 20sec if arrays are 5000
~5min if arrays are 10 000
20 000 - forever
The comparison is done like this:

Could someone give me a hint how it can be optimized?

Post #: 1

RE: How to compare Multi dimensional arrays - 5/7/2008 2:43:50 AM

Rischip

Posts: 379
Score: 2
Joined: 3/26/2007
Status: offline

Can you post the rest of the code?

_____________________________

Rischip
Author of - The Grim Linker

(in reply to lordsords)

Post #: 2

RE: How to compare Multi dimensional arrays - 5/7/2008 4:24:06 AM

lordsords

Posts: 3
Score: 0
Joined: 5/7/2008
Status: offline

The whole code would be:

MSIBase = "" 'path to changed
MSIOriginal = "" 'path to original

Set WIOBJ = CreateObject( "WindowsInstaller.Installer")
Set ODB   = WIOBJ.OpenDatabase(MSIBase, 1)
Set ODBO   = WIOBJ.OpenDatabase(MSIOriginal, 1)

wscript.echo CompareReg()

Function CompareReg()
dim aOriginalR(2000,7)
dim aTransformedR(2000,7)
strQ = "SELECT * FROM `Registry`" 
Set oViewx = ODBO.OpenView(strQ): CheckError
oViewx.Execute
c = 0
Do
Set oRec=oViewx.Fetch
If oRec Is Nothing Then Exit Do 
'msgbox oRec.StringData(0) & " x " & oRec.StringData(1) & " x " & oRec.StringData(2) & " x " & oRec.StringData(3) & " x " & oRec.StringData(4) & " x " & oRec.StringData(5) & " x " & oRec.StringData(6) & " x "
aOriginalR(c,1) = oRec.StringData(1)
aOriginalR(c,2) = oRec.StringData(2)
aOriginalR(c,3) = oRec.StringData(3)
aOriginalR(c,4) = oRec.StringData(4)
aOriginalR(c,5) = oRec.StringData(5)
aOriginalR(c,6) = oRec.StringData(6)
c=c+1
Loop
Set oViewy = ODB.OpenView(strQ): CheckError
oViewy.Execute
c = 0
Do
Set oRec=oViewy.Fetch
If oRec Is Nothing Then Exit Do 
'msgbox oRec.StringData(0) & " x " & oRec.StringData(1) & " x " & oRec.StringData(2) & " x " & oRec.StringData(3) & " x " & oRec.StringData(4) & " x " & oRec.StringData(5) & " x " & oRec.StringData(6) & " x "
aTransformedR(c,1) = oRec.StringData(1)
aTransformedR(c,2) = oRec.StringData(2)
aTransformedR(c,3) = oRec.StringData(3)
aTransformedR(c,4) = oRec.StringData(4)
aTransformedR(c,5) = oRec.StringData(5)
aTransformedR(c,6) = oRec.StringData(6)
c=c+1
Loop
For i = 0 to UBound(aTransformedR)
  For j = 0 to UBound(aOriginalR)
  if aTransformedR(i,1)=aOriginalR(j,1) and aTransformedR(i,2)=aOriginalR(j,2) and aTransformedR(i,3)=aOriginalR(j,3) and aTransformedR(i,4)=aOriginalR(j,4) and aTransformedR(i,5)=aOriginalR(j,5) and aTransformedR(i,6)=aOriginalR(j,6) then
  aTransformedR(i,7)="match"
  aOriginalR(j,7)="match"
  ' j=UBound(aOriginalR)
  ' msgbox "i="&i&"j="&j
  ' wscript.echo aTransformedR(i,1) & " " & aTransformedR(i,2) & " " & aTransformedR(i,3) & " " & aTransformedR(i,4) & " " & aTransformedR(i,5) & " " & aTransformedR(i,6)
  ' wscript.echo aOriginalR(i,1) & " " & aOriginalR(i,2) & " " & aOriginalR(i,3) & " " & aOriginalR(i,4) & " " & aOriginalR(i,5) & " " & aOriginalR(i,6)
  'msgbox aOriginalR(j,7)
  end if
  next
'msgbox i
next
i=0
For i = 0 to UBound(aTransformedR)
  if aTransformedR(i,7)="" then 
  'msgbox aTransformedR(i,1) & " " & aTransformedR(i,2) & " " & aTransformedR(i,3) & " " & aTransformedR(i,4) & " " & aTransformedR(i,5) & " " & aTransformedR(i,6)
  
  CompareReg = CompareReg & aTransformedR(i,4) & "�" & aTransformedR(i,5) & "�" & aTransformedR(i,3)& "�" & " added "& "�"
  ' else
  ' wscript.echo aTransformedR(i,7)
  end if
next
i=0
For i = 0 to UBound(aOriginalR)
  if aOriginalR(i,7)="" then 
  ' msgbox aOriginalR(i,1) & " " & aOriginalR(i,2) & " " & aOriginalR(i,3) & " " & aOriginalR(i,4) & " " & aOriginalR(i,5) & " " & aOriginalR(i,6)
  if aOriginalR(i,2) = 0 then strROOT = "HKCR\"
  if aOriginalR(i,2) = 1 then strROOT = "HKCU\"
  if aOriginalR(i,2) = 2 then strROOT = "HKLM\"
  CompareReg = CompareReg & aOriginalR(i,4) & "�" & aOriginalR(i,5) & "�" & strROOT&aOriginalR(i,3)& "�" & " deleted "& "�"
  ' else
  'wscript.echo aOriginalR(i,7)
  end if
next
End Function

(in reply to Rischip)

Post #: 3

RE: How to compare Multi dimensional arrays - 5/7/2008 5:59:57 AM

ebgreen

Posts: 4595
Score: 29
Joined: 7/12/2005
Status: offline

My first question would be why use arrays in the first place? You are taking data that is in a data structure (a recordset) and you are putting it into a more primitive data structure (array). Why not just do the comparisons between the recordsets?

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to lordsords)

Post #: 4

RE: How to compare Multi dimensional arrays - 5/7/2008 7:28:11 AM

lordsords

Posts: 3
Score: 0
Joined: 5/7/2008
Status: offline

I am not a programmer - I created this by combining several scripts
Could you provide a code sample of what you mean?

(in reply to ebgreen)

Post #: 5

RE: How to compare Multi dimensional arrays - 5/7/2008 7:53:53 AM

ebgreen

Posts: 4595
Score: 29
Joined: 7/12/2005
Status: offline

Ok, so you query a database. The query returns a recordset. That is essentially what you are looping through to add everything to an array. Instead of adding to and array, make two recordsets (oRecx and oRecy) then loop through them just like you already are. Instead of adding the contents of each record to an array, just compare each record in oRecx to the same record in oRecy.

_____________________________

"... when you are good and crazy, oooh, oooh, oooh, the sky is the limit!" - The Tick
Goog places to start:http://www.visualbasicscript.com/m_24727/tm.htm
http://www.visualbasicscript.com/m_47117/tm.htm

(in reply to lordsords)

Post #: 6

If you found our site useful please link to us <a href="http://www.visualbasicscript.com">VisualBasicScript.com</a>.

All Forums >> [Scripting] >> WSH & Client Side VBScript >> How to compare Multi dimensional arrays

Page: [1]

Jump to:

New Messages	No New Messages
Hot Topic w/ New Messages	Hot Topic w/o New Messages
Locked w/ New Messages	Locked w/o New Messages

Post New Thread

Reply to Message

Post New Poll

Submit Vote

Delete My Own Post

Delete My Own Thread

Rate Posts