Help with exclusion list!!

Forums

My Profile

Inbox

Address Book

My Subscription

My Forums

Help with exclusion list!!

Logged in as: Guest

arrSession:exec spGetSession 2,2,64131

	Active Users: There are 0 members and 0 guests.
	Users viewing this topic: none

Printable Version

All Forums >> [Scripting] >> WSH & Client Side VBScript >> Help with exclusion list!!
Do you like VisualBasicScript.com? Link to us and help spread the word about our forum. Thanks!

Page: [1]

Message

<< Older Topic Newer Topic >>

Help with exclusion list!! - 9/8/2008 7:45:38 PM

ninjamaster

Posts: 107
Score: 0
Joined: 1/23/2007
Status: offline

I have a script that checks all the PC's within our domain for the installation of a pieceof software and if detected that it is running.

Now the script works fine but I need to add an exclusion list of PC's that we know do not have the software installed.

I can build the exclusion list by creating an array on the fly from a txt file.

But this is where I'm getting lost. I can't figure out how to put my loop command in.

I've put the loop in various parts of the scrript with no joy. And I've also a funny feeling that the following will happen.....

2000pc's in domain with around 200 exclusions.

So 1st array entry will check against all 2000 PC's. Then loop round to second entry for all 2000pc's.etc..etc.. My script will take days to finish.

Is there an easier way???

I'll copy the code minus the LOOP command for reading through the array.

on Error Resume Next

Const strConfigfile = "OfficeList.txt"
strPath = "C:\temp\skinkers\"
Const ForReading = 1, ForWriting = 2, ForAppending = 3
Const TristateUseDefault = -2, TristateTrue = -1, TristateFalse = 0
Const ReadOnly = 1
Const wbemFlagReturnImmediately = &h10
Const wbemFlagForwardOnly = &h20
CreateDir strPath, strNewPath
'===Build Exclusion list array===
strExclusionList = "C:\temp\exclusion.txt"
Set objFSO2= CreateObject("Scripting.FileSystemObject")
Set openedfile = objFSO2.GetFile(strExclusionList)
Set TextStream = openedfile.OpenAsTextStream(ForReading, TristateUseDefault)
Dim arrExList()
intSize = 0

Do Until TextStream.AtEndOfStream
' Read current line
strExclusion = TextStream.readline
ReDim Preserve arrExList(intSize)
arrExList(intSize) = strExclusion
intSize = intSize + 1

Loop
'=== End array build ===

Set objFSO= CreateObject("Scripting.FileSystemObject")
Set objShell = CreateObject("WScript.Shell")

' Open and read config file into text stream
Set openedfile = objFSO.GetFile(strConfigfile)
Set TextStream = openedfile.OpenAsTextStream(ForReading, TristateUseDefault)

' Step through office list file until end of file
Do Until TextStream.AtEndOfStream

' Read current line
 strOffice = TextStream.readline
 
 strFile = strNewPath & strOffice & ".log"
strNotInstFile = strNewPath & strOffice & " Not installed.log"
strNotRunFile = strNewPath & strOffice & " Not Running.log"

Const ADS_SCOPE_SUBTREE = 2

Set objShell = CreateObject("WScript.Shell")

Set objConnection = CreateObject("ADODB.Connection")
Set objCommand =   CreateObject("ADODB.Command")
objConnection.Provider = "ADsDSOObject"
objConnection.Open "Active Directory Provider"
Set objCommand.ActiveConnection = objConnection

objCommand.Properties("Page Size") = 1000
objCommand.Properties("Searchscope") = ADS_SCOPE_SUBTREE

objCommand.CommandText = "SELECT CN FROM 'LDAP://ou=" & strOffice & ",ou=sites,dc=Company,dc=net' WHERE objectCategory='computer'"  
Set objRecordSet = objCommand.Execute

objRecordSet.MoveFirst

strPCTotal = 0
strReply = 0
strNoReply = 0 
strInst = 0
strNotInst = 0
strRunning = 0
strNotRunning = 0
strEx = 0
Do Until objRecordSet.EOF

strComputer = objRecordSet.Fields("CN").Value

addtolog strFile, " - Checking"
strPCTotal = strPCTotal + 1

PingPC
   
   objRecordSet.MoveNext
   
   strComputer = Empty
   addtolog strFile, " "
  
Loop

addtolog strFile, "Total number of PC's - " & strPCTotal
addtolog strFile, "Number PC's currently switched on - " & strReply
addtolog strFile, "Number PC's  installed on - " & strInst
addtolog strFile, "Number of installed PC's with  running - " & strRunning
addtolog strFile, "Number of installed PC's with  NOT running - " & strNotRunning
addtolog strFile, "Number of PC's NOT installed on - " & strNotInst
addtolog strFile, "Number of PC's NOT switched on - " & strNoReply

WScript.Echo strOffice & " -  check complete!"

Loop

sub CreateDir (strPath, strNewPath)
Set oFSO = CreateObject("Scripting.FileSystemObject")
'Set folders
strNewPath = strPath & Day(Date) & "." & Month(Date) & "." & Year(Date) & "\"
oFSO.CreateFolder strNewPath

End Sub

Function PingPC
' Run ping on this computer
Set objExec = objShell.Exec("ping -n 1 -w 400 " & strComputer)

' Grab results from STDOUT and make lower case
strPingResults = LCase(objExec.StdOut.ReadAll)
' Check ping status
If InStr(strPingResults, "reply from") Then
strReply = strReply + 1
CheckInstall

Else
addtolog strFile, " - No Reply"
strNoReply = strNoReply + 1
End If

End Function
Function CheckInstall
Set oFSO = CreateObject("Scripting.FileSystemObject")

If oFSO.FileExists ("\\" & strComputer & "\c$\Program Files\software.exe") Then
addtolog strFile, " - installed"
strInst = strInst + 1
CheckService
Else
addtolog strFile, " - NOT installed"

WhoIsLoggedOnInst

strNotInst = strNotInst + 1
End If

End Function

Function CheckService
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")

Set colProcessList = objWMIService.ExecQuery ("Select * from Win32_Process where Name = 'Software.exe'")

If colProcessList.count > 0 Then
For Each objProcess in colProcessList
addtolog strFile, " -  running" 
strRunning = strRunning + 1
Next
Else 
addtolog strFile, " -  NOT running"

WhoIsLoggedOnRun

strNotRunning = strNotRunning + 1
End If

End Function
Function WhoIsLoggedOnInst

Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colItems = objWMIService.ExecQuery("Select * From Win32_ComputerSystem")
For Each objItem in colItems
addtolog strNotInstFile, VbCrLf & objItem.UserName & VbCrLf
Next
End Function

Function WhoIsLoggedOnRun

Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colItems = objWMIService.ExecQuery("Select * From Win32_ComputerSystem")
For Each objItem in colItems
addtolog strNotRunFile, VbCrLf & objItem.UserName & VbCrLf
Next
End Function

Sub addtolog (strFile, strLine)
On Error Resume Next
Dim objFS
If strLine <> "" Then
    Set objFs = Wscript.CreateObject("Scripting.FileSystemObject")
    Set objMyFile = objFs.OpenTextFile(strFile, 8, True)
    objMyFile.WriteLine strComputer & vbTab & strLine
    objMyFile.Close
End If
End Sub

< Message edited by ninjamaster -- 9/8/2008 7:51:19 PM >

Post #: 1

RE: Help with exclusion list!! - 9/8/2008 9:21:06 PM

ginolard

Posts: 1066
Score: 21
Joined: 8/10/2005
Status: online

Ok, before I address this, I would make a suggestion regarding your PingPC function.

At the moment, there's no point in it being a Function because you don't return a value. I would change it to this



Then, you can just do the following in your Loop



Now, as for your exclusion list I would use a Dictionary object instead of an Array. And use the Exists method to check whether or not the PC you want to check is in the Dictionary

You would do that check after this line



Go and read up on Dictionaries and have a bash at it. If you still need help, come back here

_____________________________

Author of ManagePC - http://managepc.net
AD Query Template - http://www.visualbasicscript.com/m_40609/tm.htm
Consolidated Scripting Framework - http://www.visualbasicscript.com/m_59109/tm.htm

(in reply to ninjamaster)

Post #: 2

RE: Help with exclusion list!! - 9/8/2008 9:25:34 PM

ninjamaster

Posts: 107
Score: 0
Joined: 1/23/2007
Status: offline

Excellent. I was hoping there would be an easier way!

And thanks for the PCPing rewrite ;)

(in reply to ginolard)

Post #: 3

RE: Help with exclusion list!! - 9/8/2008 10:26:29 PM

ninjamaster

Posts: 107
Score: 0
Joined: 1/23/2007
Status: offline

Hhhm. Ok I have the following. But PC's I have in the exclusion file and showing as included when ran? :#

< Message edited by ninjamaster -- 9/8/2008 10:28:02 PM >

(in reply to ginolard)

Post #: 4

RE: Help with exclusion list!! - 9/8/2008 11:18:32 PM

ninjamaster

Posts: 107
Score: 0
Joined: 1/23/2007
Status: offline

It's OK. Got it. Me being stupid!

If dicExclusionList.Exists(strComputer) Then

should of course read

If objDictionary.Exists(strComputer) Then

:)

(in reply to ninjamaster)

Post #: 5

If you found our site useful please link to us <a href="http://www.visualbasicscript.com">VisualBasicScript.com</a>.

All Forums >> [Scripting] >> WSH & Client Side VBScript >> Help with exclusion list!!

Page: [1]

Jump to:

New Messages	No New Messages
Hot Topic w/ New Messages	Hot Topic w/o New Messages
Locked w/ New Messages	Locked w/o New Messages

Post New Thread

Reply to Message

Post New Poll

Submit Vote

Delete My Own Post

Delete My Own Thread

Rate Posts